Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WiFi connection on RHEL based systems #482

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

epheo
Copy link
Contributor

@epheo epheo commented Feb 14, 2024

This fix #481

On RHEL based systems, the version is in the form of 1.44.2-1.fc39 wich raises an error when trying to compare it with the Version class.

This fix remove non alphabetical values from the version string if any.

On RHEL based systems, the version is in the form of 1.44.2-1.fc39
wich raises an error when trying to compare it with the Version class.

This fix remove non alphabetical values from the version string if any.
@epheo
Copy link
Contributor Author

epheo commented Feb 15, 2024

Unsure how to proceed regarding the failing CI job but it seems that it is fetching my (forked) development branch out of the main repo (which I don't have access to).
I also do not have the permissions to add someone as a Reviewer as mentioned in the doc. @tcamise-gpsw

@tcamise-gpsw tcamise-gpsw self-assigned this Apr 10, 2024
@tcamise-gpsw tcamise-gpsw merged commit 3924ed9 into gopro:main Apr 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nmcli version check fails on RHEL based systems (Fedora)
2 participants